HYPERFLEET-1108 - feat: add support for custom labels in Helm chart#187
Conversation
|
Warning Review limit reached
More reviews will be available in 36 minutes and 2 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Risk Score: 0 —
|
| Signal | Detail | Points |
|---|---|---|
| PR size | 13 lines | +0 |
| Sensitive paths | none | +0 |
Computed by hyperfleet-risk-scorer
mliptak0
force-pushed
the
HYPERFLEET-1108
branch
from
a6622b9 to
daa2c28
Compare
Add support for custom labels via .Values.labels that are applied to all Helm-managed resources (Deployment, Service, ServiceAccount, ClusterRole, ClusterRoleBinding, ConfigMaps, etc.). Include commented-out example in values.yaml to make the feature discoverable without requiring inspection of _helpers.tpl. Enables E2E test cleanup by labeling resources with run IDs. Co-Authored-By: Claude <noreply@anthropic.com>
mliptak0
force-pushed
the
HYPERFLEET-1108
branch
from
daa2c28 to
91eec5e
Compare
mliptak0
changed the title
|
/retest |
| # environment: production | ||
| # team: platform | ||
| # hyperfleet-e2e-run: e2e-20260615-102422-bb5nfo2d | ||
| # labels: {} |
There was a problem hiding this comment.
| # labels: {} | |
| labels: {} |
nit: Every other empty-map default in this file is uncommented (podLabels: {}, podAnnotations: {}, affinity: {}, serviceMonitor.labels: {}). Uncomment so the key is visible in helm show values and follows the same pattern.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rafabene The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 592d5cf
into
openshift-hyperfleet:main
## Summary
- HYPERFLEET-1108
- Uncomment `labels: {}` so the key is visible in `helm show values`
output
Addresses nitpick from
[#187](#187 (comment))
that was merged before the fix could be applied.
## Test Plan
- [ ] `make test-helm` passes
2 participants
Summary
Add possibility to set labels when installing chart
Test Plan
make test-allpassesmake lintpassesmake test-helm(if applicable)